Skip to content

chore(select): panel class example not working and pluralize custom trigger #11999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2018
Merged

chore(select): panel class example not working and pluralize custom trigger #11999

merged 1 commit into from
Jul 5, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 30, 2018 •
edited
Loading

  • Fixes the "Custom panel class" example not working due to style encapsulation.
  • Pluralizes the example in the "Custom trigger" demo.

@crisbeto
chore(select): panel class example not working and pluralize custom t…
737b02d 
…rigger

* Fixes the "Custom panel class" example not working due to style encapsulation.
* Pluralizes the example in the "Custom trigger" demo.
@crisbeto crisbeto added docs This issue is related to documentation pr: merge safe labels Jun 30, 2018
@crisbeto crisbeto requested review from amcdnl and jelbourn as code owners June 30, 2018 16:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 30, 2018
@crisbeto crisbeto changed the title chore(select): panel class example not working and pluralize custom t… chore(select): panel class example not working and pluralize custom trigger Jun 30, 2018
josephperrott
josephperrott approved these changes Jul 2, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 2, 2018
@mmalerba mmalerba merged commit 9b7d56c into angular:master Jul 5, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@crisbeto @victoriaaa234
chore(select): panel class example not working and pluralize custom t…
697ceae 
…rigger (#11999)

* Fixes the "Custom panel class" example not working due to style encapsulation.
* Pluralizes the example in the "Custom trigger" demo.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @josephperrott @jelbourn @googlebot @mmalerba