Skip to content

fix(drag-drop): Use correct drop event #12092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(drag-drop): Use correct drop event #12092

wants to merge 1 commit into from

Conversation

pas2al
Copy link
Contributor

@pas2al pas2al commented Jul 6, 2018

Fixes the drop event name in the drag-drop demo. See #12086

@pas2al pas2al requested a review from crisbeto as a code owner July 6, 2018 16:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 6, 2018
@ngbot
Copy link

ngbot bot commented Jul 6, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@pas2al
Copy link
Contributor Author

pas2al commented Jul 7, 2018

How do we get travis green?

@crisbeto
Copy link
Member

crisbeto commented Jul 7, 2018

Looks like it was a flake.

@pas2al
Copy link
Contributor Author

pas2al commented Jul 11, 2018

Fixed in #12104

@pas2al pas2al closed this Jul 11, 2018
@pas2al pas2al deleted the patch-1 branch July 11, 2018 13:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants