Skip to content

fix(datepicker): showing dot in high contrast mode after popup has closed #12099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 7, 2018

Fixes the datepicker's popup showing a 1x1 pixel dot in high contrast mode, after the calendar has been closed. The dot comes from the outline that we add to the popup which collapses after we detach the overlay.

For reference:
angular_material_ -_microsoft_edge_2018-07-07_18-15-16

…osed

Fixes the datepicker's popup showing a 1x1 pixel dot in high contrast mode, after the calendar has been closed. The dot comes from the outline that we add to the popup which collapses after we detach the overlay.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 7, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner July 7, 2018 16:25
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 7, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2018
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 10, 2018
Removes the `panelClass` when the overlay is detached. This ensures that any overlay styling that targets the panel isn't left behind while the panel is detached.

Relates to angular#12099.
jelbourn pushed a commit that referenced this pull request Jul 11, 2018
Removes the `panelClass` when the overlay is detached. This ensures that any overlay styling that targets the panel isn't left behind while the panel is detached.

Relates to #12099.
@jelbourn jelbourn merged commit 6a472eb into angular:master Jul 11, 2018
jelbourn pushed a commit that referenced this pull request Jul 12, 2018
Removes the `panelClass` when the overlay is detached. This ensures that any overlay styling that targets the panel isn't left behind while the panel is detached.

Relates to #12099.
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
…osed (#12099)

Fixes the datepicker's popup showing a 1x1 pixel dot in high contrast mode, after the calendar has been closed. The dot comes from the outline that we add to the popup which collapses after we detach the overlay.
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
Removes the `panelClass` when the overlay is detached. This ensures that any overlay styling that targets the panel isn't left behind while the panel is detached.

Relates to #12099.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants