Skip to content

feat(drag-drop): add support for multiple handles and handles that are added after init #12102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2018
Merged

feat(drag-drop): add support for multiple handles and handles that are added after init #12102

merged 1 commit into from
Jul 9, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 8, 2018 •
edited
Loading

  • Fixes a TODO about supporting handles that are added after init.
  • Adds the ability to have more than one handle in a draggable.
  • Enables bubbling for the fake mouse events.

@crisbeto crisbeto requested a review from devversion as a code owner July 8, 2018 09:28
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 8, 2018
@crisbeto crisbeto force-pushed the drag-multiple-handles branch from d4825e8 to abe55ee Compare July 8, 2018 09:51
josephperrott
josephperrott approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: master only labels Jul 9, 2018
@crisbeto
feat(drag-drop): add support for multiple handles and handles that ar…
855fe18 
…e added after init

* Fixes a TODO about supporting handles that are added after init.
* Adds the ability to have more than one handle in a draggable.
* Enables bubbling for the fake mouse events.
@crisbeto crisbeto force-pushed the drag-multiple-handles branch from abe55ee to 855fe18 Compare July 9, 2018 17:40
@josephperrott josephperrott merged commit f2963bc into angular:master Jul 9, 2018
josephperrott pushed a commit that referenced this pull request Jul 9, 2018
@crisbeto @josephperrott
feat(drag-drop): add support for multiple handles and handles that ar…
95ebf9a 
…e added after init (#12102)
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@crisbeto @victoriaaa234
feat(drag-drop): add support for multiple handles and handles that ar…
2328654 
…e added after init (#12102)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @josephperrott @jelbourn @googlebot