fix(overlay): wait for panel to detach before removing panelClass #13199
Conversation
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
What's with the CI failures? |
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
Currently we remove the `panelClass` as soon as `detach` is called, however the pane may still be animating. These changes wait for the panel to be done animating and to be removed from the DOM, before removing the class. Fixes angular#13189.
crisbeto
force-pushed
the
13189/overlay-detach-panel-class
branch
from
ba83b32 to
6515008
Compare
|
Looks like it needed an extra null check. It's good to go now. |
…gular#13199) Currently we remove the `panelClass` as soon as `detach` is called, however the pane may still be animating. These changes wait for the panel to be done animating and to be removed from the DOM, before removing the class. Fixes angular#13189.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently we remove the
panelClassas soon asdetachis called, however the pane may still be animating. These changes wait for the panel to be done animating and to be removed from the DOM, before removing the class.Fixes #13189.