fix(select): handle home and end keys on closed select #13278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the selection to the first/last item when pressing home/end on a closed `mat-select`, similarly to a native `select`.
googlebot
added
the
cla: yes
mmalerba
reviewed
Sep 24, 2018
|
|
||
| // Open the select on ALT + arrow key to match the native <select> | ||
| if (isOpenKey || ((this.multiple || event.altKey) && isArrowKey)) { | ||
| event.preventDefault(); // prevents the page from scrolling down when pressing space | ||
| this.open(); | ||
| } else if (!this.multiple) { | ||
| this._keyManager.onKeydown(event); | ||
| if (keyCode === HOME || keyCode === END) { |
There was a problem hiding this comment.
Would it make more sense to just add this to ListKeyManager?
There was a problem hiding this comment.
We used to have them on the ListKeyManager, but we removed them because they don't make sense in all cases (e.g. on an input).
mmalerba
added
pr: lgtm
action: merge
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
Moves the selection to the first/last item when pressing home/end on a closed `mat-select`, similarly to a native `select`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the selection to the first/last item when pressing home/end on a closed
mat-select, similarly to a nativeselect.