fix(datepicker): compilation errors with ViewEngine

[crisbeto]

Fixes a few compilation errors that only happen when the date range picker is compiled with ViewEngine.

[mmalerba]

LGTM

[mmalerba]

do we have a project or something for stuff that needs to be fixed before 10.0.0? (edit: I added it to the 10.0.0 milestone, I assume that's what its for)

[jelbourn]

LGTM

[devversion]

@crisbeto do you know why this hasn't been captured by our View Engine test job?

[crisbeto]

No idea, I randomly had to run the dev app with --config=view-engine to test something different and these errors showed up.

[devversion]

@crisbeto I looked into it. I think the protected member change is reasonable in View Engine, but I'm surprised by the other one:

src/components-examples/material/datepicker/date-range-picker-overview/date-range-picker-overview-example.html(4,5): Directive MatStartDate, Property 'rangePicker' does not exist on type 'MatDateRangeInputParent<any>'.

Does that mean that Ivy doesn't properly check host bindings? Should we submit a bug report?

[crisbeto]

By the looks of it, all 3 failures are from host bindings.

[devversion]

@crisbeto yeah, but the one with the protected members doesn't seem to surface because the factories in Ivy are static properties of the directive/component. So it's possible to now use private or protected for expressions that are referenced in templates/host bindings.

Though, that wouldn't tell us whether host bindings are checked or not in Ivy. Should we look into this on the framework side? I'd expect View Engine not to be stricter than Ivy with strict templates enabled.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}