fix(theming): fix broken sass expressions nested in theme classes #4145
+101
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
This was referenced Apr 18, 2017
kara
added
pr: needs rebase
and removed
action: merge
|
@crisbeto Can you rebase this? |
* Fixes certain theme selectors being broken due to uses of the `&` operator at the end of the selector. * Adds a custom Stylelint rule to catch future improper uses of the ampersand inside themes. Relates to angular#3928. Fixes angular#4077.
crisbeto
force-pushed
the
theme-amp-rule
branch
from
812f1f2 to
ee0c019
Compare
crisbeto
added
action: merge
|
Rebased. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&operator at the end of the selector.Relates to #3928.
Fixes #4077.