feat(overlay): add providers for overriding the scroll strategies per component #5134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Just needs rebase |
crisbeto
force-pushed
the
4093/scroll-strategy-providers
branch
from
7d682fd to
b89d167
Compare
crisbeto
added
action: merge
kara
added
pr: needs rebase
and removed
action: merge
|
@crisbeto Can you rebase? |
crisbeto
force-pushed
the
4093/scroll-strategy-providers
branch
from
b89d167 to
d4c73e5
Compare
crisbeto
added
action: merge
aitboudad
reviewed
Jun 19, 2017
|
|
||
| /** @docs-private */ | ||
| export function MD_AUTOCOMPLETE_SCROLL_STRATEGY_PROVIDER_FACTORY(overlay: Overlay) { | ||
| return () => overlay.scrollStrategies.reposition(); |
There was a problem hiding this comment.
wouldn't better to handle to case of IOS too (related to #5187)
return () => platform.IOS ? overlay.scrollStrategies.block() : overlay.scrollStrategies.reposition();
jelbourn
added
the
merge: caretaker note
|
Caretaker note: someone inside google is extending |
|
@crisbeto can you rebase? |
crisbeto
force-pushed
the
4093/scroll-strategy-providers
branch
from
d4c73e5 to
778ca51
Compare
|
Rebased @jelbourn. |
crisbeto
force-pushed
the
4093/scroll-strategy-providers
branch
from
778ca51 to
7b169e8
Compare
crisbeto
force-pushed
the
4093/scroll-strategy-providers
branch
from
7b169e8 to
fc7823d
Compare
|
@crisbeto can you rebase again? |
crisbeto
force-pushed
the
4093/scroll-strategy-providers
branch
from
fc7823d to
5bad898
Compare
|
Rebased @jelbourn. |
|
@crisbeto appears to be some lint errors now |
… component Adds providers to the autocomplete, connected overlay, datepicker, dialog, menu, select and tooltip components, that allow for the default scroll strategy to be overwritten. Fixes angular#4093.
crisbeto
force-pushed
the
4093/scroll-strategy-providers
branch
from
5bad898 to
100e123
Compare
|
Sorted out the linting error @jelbourn. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds providers to the autocomplete, connected overlay, datepicker, dialog, menu, select and tooltip components, that allow for the default scroll strategy to be overwritten.
Fixes #4093.