chore(async/await): document async/await better #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjelin
commented
Nov 1, 2016
|
|
||
| `async` functions and the `await` keyword are likely coming in ES7, and | ||
| available via several compilers. At the moment, they often break the WebDriver | ||
| control flow |
sjelin
commented
Nov 1, 2016
| sharedVal = await driver.getValueA(); // Async unwraps this to 'a' | ||
| expect(sharedVal).toBe('a'); | ||
| await driver.sleep(1000); // Normally you wouldn't need to `await` this, but | ||
| // the control flow is broken for async functions |
There was a problem hiding this comment.
here too. I always forget that...
cnishina
pushed a commit
to cnishina/jasminewd
that referenced
this pull request
Jan 6, 2017
cnishina
pushed a commit
that referenced
this pull request
Jan 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old documentation missed the major issue described here: SeleniumHQ/selenium#3037