Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Use md-nav-list for guide list #144

Merged
merged 2 commits into from
Apr 8, 2017
Merged

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Apr 8, 2017

Adds on top of #80, but I remove the <table> since it's not quite right to use that inside of a list.

I also changed the h1 style to be regular text.

@jelbourn jelbourn requested a review from crisbeto April 8, 2017 19:01
@jelbourn jelbourn added cla: yes and removed cla: no labels Apr 8, 2017
@jelbourn jelbourn mentioned this pull request Apr 8, 2017
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor issue.

@import '~@angular/material/theming';

@mixin guide-list-theme($theme) {
$primary: map-get($theme, primary);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these variables aren't being used, perhaps we can get rid of them?

@googlebot googlebot added cla: no and removed cla: yes labels Apr 8, 2017
@jelbourn jelbourn added cla: yes and removed cla: no labels Apr 8, 2017
@jelbourn jelbourn merged commit 4602018 into angular:master Apr 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants