This repository was archived by the owner on Dec 18, 2024. It is now read-only.
feat: add version and version picker #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
reviewed
Mar 8, 2018
src/app/shared/version/version.ts
Outdated
| title: '5.2.4' | ||
| }, | ||
| { | ||
| url: `http://material2-docs-dev.firebaseapp.com`, |
There was a problem hiding this comment.
is this supposed to be pointed at the dev one?
There was a problem hiding this comment.
No... I will update the url once we set up the domain for v5.
|
|
||
| materialVersion = materialVersion; | ||
|
|
||
| displayVersion = materialVersion.match(/\d+.\d+.\d+/)[0]; |
There was a problem hiding this comment.
extract the regex into a var
There was a problem hiding this comment.
Done. Thanks for review!
mmalerba
approved these changes
Mar 8, 2018
|
Updated the pr with actual urls. The v5 is available https://v5.material.angular.io/ (without version picker) |
jelbourn
approved these changes
Mar 9, 2018
package.json
Outdated
| "publish-dev": "npm run build-themes && ng build --aot --prod && firebase use material2-docs-dev && firebase deploy" | ||
| "publish-dev": "npm run build-themes && ng build --aot --prod && firebase use material2-docs-dev && firebase deploy", | ||
| "publish-v5-prod": "npm run build-themes && ng build --aot --prod && firebase use v5-material-angular-io && firebase deploy", | ||
| "publish-v5-dev": "npm run build-themes && ng build --aot --prod && firebase use material2-docs-5 && firebase deploy" |
There was a problem hiding this comment.
File an issue saying we should create a deploy script for this rather than adding more npm commands over time?
There was a problem hiding this comment.
Added file tools/deploy.sh and updated package.json
jelbourn
approved these changes
Mar 9, 2018
This was referenced Apr 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://material2-docs-dev.firebaseapp.com/