This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Provide access to the processed configuration block #1724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, maybe add a test though? It's pretty simple to do, just put a jasmine/protractor test in |
|
I added a simple test as you suggested. |
|
Looks good to me - I'm going to update the commit message to match with our pattern and merge. |
|
|
||
| describe('configuration elements', function() { | ||
| it('should have access to the processed config block', function() { | ||
| browser.getProcessedConfig().then(function(config) { |
There was a problem hiding this comment.
This will actually fail in our CI where the browser is not always Chrome - I'll modify slightly.
|
Thanks for all the help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of PR #1708 with a few changes: