This repository was archived by the owner on Jul 29, 2024. It is now read-only.
feat(a11yPlugin): add support for Tenon.io #1867
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcysutton
force-pushed
the
a11y-tenon
branch
from
86f1913 to
14608c3
Compare
|
One thing we will need to document: in Tenon, scripts have to be accessible from the page source as a string, for example loaded through a CDN. Otherwise Tenon won't be able to test expressions coming from Angular. I ran into this when supplying an alt attribute as an expression. To get around it for now, I just hard-coded a value. |
| * printAll: false, // whether the plugin should log API response | ||
| * }, | ||
| * chromeA11YDevTools: false, | ||
| * path: 'node_modules/protractor.plugins/accessiblity' |
There was a problem hiding this comment.
typo: .plugins instead of /plugins
|
Looks good overall, just a couple comments. |
marcysutton
force-pushed
the
a11y-tenon
branch
from
14608c3 to
ea0f72d
Compare
|
@juliemr FYI I pushed all changes except for the duration thing, which I figured could come later. Let me know if there's anything else you'd like to see updated. |
|
Looks good. Merged as 13d34c9 |
|
Woooot! 🎉 @karlgroves Tenon is merged into Protractor master! |
|
👍 |
|
w00t! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #1854, this change adds support for the Tenon accessibility testing framework. I removed my API key from the plugin config files, so the Protractor internal tests won't run against Tenon as-is. The Chrome Accessibility Dev Tools will still run, though.
One thing I noticed was that the
accessibility-developer-toolspackage was missing from package.json. I added it back in along with theentitiespackage for decoding HTML strings, which has no dependencies.