This repository was archived by the owner on Jul 29, 2024. It is now read-only.
fix(accessibility): improve output for long elements #1900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just printing the first N characters of the element's template, print the first and last N/2. See angular#1854
| @@ -175,6 +175,15 @@ function runChromeDevTools(config) { | |||
| var elementPromises = [], | |||
| elementStringLength = 200; | |||
|
|
|||
| function trimText(text) { | |||
| if (text.length > elementStringLength) { | |||
| return text.substring(0, elementStringLength / 2) + ' ... ' | |||
There was a problem hiding this comment.
This will have a total length of elementStringLength + 5. Is that correct?
There was a problem hiding this comment.
Yeah (there's also some tabs at the beginning, so it's not the whole output string length anyway...).
|
LGTM |
|
👍 |
|
Thanks! Merged as fb92be6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just printing the first N characters of the element's template,
print the first and last N/2.
See #1854