feat(driver providers): Add BrowserStack support. #2671
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
They signed the CLA back in #2599 |
sjelin
force-pushed
the
browserstack
branch
2 times, most recently
from
72e4edb to
f0a0294
Compare
|
They're OK with these contributions. |
|
@juliemr I'm getting ECONNREFUSED but I don't know why. Can you take a look? |
|
Have a look at this PR |
| // | ||
| // 1. seleniumServerJar - to start a standalone Selenium Server locally. | ||
| // 2. seleniumAddress - to connect to a Selenium Server which is already | ||
| // running. | ||
| // 3. sauceUser/sauceKey - to use remote Selenium Servers via Sauce Labs. | ||
| // 4. directConnect - to connect directly to the browser Drivers. | ||
| // 4. bstackUser/bstackKey - to use remote Selenium Servers via BrowserStack. |
There was a problem hiding this comment.
Let's be wordy but precise and use browserStackUser and browserStackKey
|
For the tests, we'll also have to add a tunnel so that browserstack can access the test server on Or the CL that @vedharish sent - I don't really have a preference between using curl to download or using the browserstacktunnel-wrapper npm module. |
sjelin
force-pushed
the
browserstack
branch
9 times, most recently
from
57a8de4 to
9b2129c
Compare
|
All comments addressed. I couldn't get the angular team's method to work so I went with @vedharish's PR. If you've changed your mind and decided consistency is important I'll take another look and the Angular method. |
|
Thanks, looks good! |
|
Make sure the commits are squashed and have good messages. |
Also added BrowserStack to CI Closes angular#1013
Also added BrowserStack to CI
Closes #1013