This repository was archived by the owner on Jul 29, 2024. It is now read-only.
feat(plugins) Calculate skipAngularStability dynamically. #3023
+74
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,6 +126,18 @@ function printPluginResults(specResults) { | |||
| } | |||
|
|
|||
| /** | |||
| * Returns true if any loaded plugin has skipAngularStability enabled. | |||
There was a problem hiding this comment.
This should go at the end of the file probably
|
Small style change needed, some kind of test would be good too probably |
heathkit
force-pushed
the
dynamic-skip
branch
2 times, most recently
from
457cba2 to
da33e8f
Compare
|
Added tests and fixed that style issue. |
This allows plugins to turn Protractor's default synchronization on and off as needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows plugins to turn Protractor's default synchronization on and
off as needed.