Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

feat(webdriver): extract webdriver-manager into a separate node module #3068

Merged
merged 3 commits into from
Jun 8, 2016
Merged

feat(webdriver): extract webdriver-manager into a separate node module #3068

merged 3 commits into from
Jun 8, 2016

Conversation

cnishina
Copy link
Contributor

@cnishina cnishina commented Mar 28, 2016 •
edited
Loading

closes #607, closes #2402

@NickTomlin
Copy link
Contributor

So much 👏 🎊

This is slightly OT (feel free to ignore if i've missed out on a conversation elsewhere), but have we considered asking the webdriver-manager folks to transfer ownership to the angular org and publishing this there?

@cnishina cnishina mentioned this pull request Apr 1, 2016
Closed
@juliemr juliemr self-assigned this Apr 4, 2016
@sjelin
Copy link
Contributor

sjelin commented Apr 6, 2016

Nit: commit should say "extract webdriver-tool into..."

re: @NickTomlin
Yeah, Craig, if you want I'm sure you could get a repo under angular.

Also, we are the webdriver-manager folks 😄

@juliemr
Copy link
Member

juliemr commented Apr 6, 2016

We're discussing with the owner of webdriver-manager on npm - conclusion TBD.

@NickTomlin
Copy link
Contributor

@sjelin ah yeah I should have been clearer, I mean the community npm webdriver-manager fork

Glad to hear we are talking with the NPM owner. Hopefully we can work that out!

@cnishina cnishina changed the title feat(webdriver): extract webdriver into a separate node module feat(webdriver): extract webdriver-manager into a separate node module Apr 7, 2016
@cnishina
Copy link
Contributor Author

cnishina commented Apr 7, 2016

Name change from webdriver-tool to webdriver-manager. Updating this pr to reflect this.

Should not be merged until we publish to npm... also shouldn't work since package.json is looking for version 10 of webdriver-manager

@cnishina cnishina force-pushed the pr_remove_webdriver branch 2 times, most recently from 8452bdb to b79d915 Compare April 7, 2016 22:08
@juliemr juliemr modified the milestones: Icebox, 3.4.0 Apr 25, 2016
@cnishina cnishina force-pushed the pr_remove_webdriver branch from b79d915 to 77c78aa Compare April 26, 2016 23:58
@cnishina cnishina force-pushed the pr_remove_webdriver branch 3 times, most recently from 386f7bd to 0536aec Compare April 27, 2016 21:23
@cnishina cnishina force-pushed the pr_remove_webdriver branch 2 times, most recently from 531d409 to bc05cc4 Compare May 12, 2016 07:32
@cnishina
Copy link
Contributor Author

browserStack tests are failing which needs to be addressed.

@cnishina cnishina force-pushed the pr_remove_webdriver branch from bc05cc4 to 3bd0252 Compare May 12, 2016 15:41
@cnishina cnishina force-pushed the pr_remove_webdriver branch 5 times, most recently from 8fb2e3c to 1445c4e Compare May 13, 2016 23:20
@cnishina cnishina force-pushed the pr_remove_webdriver branch 4 times, most recently from bee998d to 99eb425 Compare May 16, 2016 19:05
@cnishina cnishina force-pushed the pr_remove_webdriver branch from 99eb425 to 0cd63d7 Compare May 16, 2016 19:06
juliemr
juliemr reviewed Jun 1, 2016
View reviewed changes
README.md
@@ -45,9 +45,10 @@ Clone the github repository:
npm install
cd ..

Start up a selenium server. By default, the tests expect the selenium server to be running at `http://localhost:4444/wd/hub`. A selenium server can be started with `webdriver-manager`.
Start up a selenium server. By default, the tests expect the selenium server to be running at `http://localhost:4444/wd/hub`. A selenium server can be started with [webdriver-manager](https://github.com/angular/webdriver-manager).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add something like: "which is included in bin/webdriver-manager"?

@juliemr
Copy link
Member

juliemr commented Jun 1, 2016

We should mention in the commit description that this will change the filenames by giving everything versions.

@juliemr juliemr assigned cnishina and unassigned juliemr Jun 1, 2016
@cnishina cnishina force-pushed the pr_remove_webdriver branch 2 times, most recently from 8994bd0 to 1532aec Compare June 8, 2016 21:02
@cnishina cnishina force-pushed the pr_remove_webdriver branch from 1532aec to 99ba59b Compare June 8, 2016 21:05
@cnishina
Copy link
Contributor Author

cnishina commented Jun 8, 2016

  • As discussed, versioning of binaries was previously added in ~3.2
  • Fixes for webdriver-manager 10.0.4 for configuration file and path issues.
  • Removed the config.json. This will be managed now by webdriver-manager
  • wedriver-manager downloads the file to the node_modules/webdriver-manager/selenium folder. This will no longer appear in the protractor directory.

@cnishina cnishina merged commit 85209f4 into angular:master Jun 8, 2016
@cnishina cnishina deleted the pr_remove_webdriver branch June 14, 2016 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@cnishina cnishina

Labels
cla: yes pr: LGTM pr: needs cleanup
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Add ability to create chromedriver.log Extract "webdriver-manager" as an independent Node module
5 participants
@cnishina @NickTomlin @sjelin @juliemr @googlebot