This repository was archived by the owner on Jul 29, 2024. It is now read-only.
fix(export): export selenium-webdriver #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
changed the title
|
Needs testing. |
|
|
cnishina
force-pushed
the
403_selenium_webdriver
branch
7 times, most recently
from
db2acb5 to
2aa7c12
Compare
| export var ExpectedConditions: ProtractorExpectedConditions = | ||
| global['protractor']['ExpectedConditions']; | ||
| export let protractor: Ptor = global['protractor']; | ||
| export let browser: ProtractorBrowser = global['protractor']['browser']; |
There was a problem hiding this comment.
Can we not do: export let browser: ProtractorBrowser = protractor.['browser'];?
There was a problem hiding this comment.
Yes. protractor.browser or protractor['browser']
There was a problem hiding this comment.
That seems simpler, let's change to that then.
cnishina
force-pushed
the
403_selenium_webdriver
branch
from
79e4339 to
4801b25
Compare
| } | ||
|
|
||
| export var Protractor = new Ptor(); |
There was a problem hiding this comment.
I think this should be lowercase, since it's an instance.
export var protractor = new Ptor();
|
One more thing, then LGTM |
- rename to ProtractorBrowser to be able to export selenium-webdriver Browser as Browser
…vascript global objects
- adds missing npm run tsc to spec/install/package.json - checked that the objects exist under the protractor namespace closes angular#2092
- globals to use protractor.browser instead of global['protractor']['browser'] - set subfolders as part of a utils object - clean up tests (mocks and typings clean up) - fix typo util should be until with a missing until test
cnishina
force-pushed
the
403_selenium_webdriver
branch
from
885e30f to
481ed2f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3427
closes #2092