This repository was archived by the owner on Jul 29, 2024. It is now read-only.
feat(util): Allow more verbose logging with multiple sessions (#2985). #3499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Giving this to Craig since he'd like to do more reviews. |
| @@ -200,6 +200,13 @@ exports.config = { | |||
| // Use a number less than 1 to denote unlimited. Default is unlimited. | |||
| maxSessions: -1, | |||
|
|
|||
| // Whether or not to buffer output when running tests on multiple browsers | |||
| // in parallel. By default, when running multiple browser sessions results | |||
There was a problem hiding this comment.
Nit: "By default, when running multiple browser sessions, the results"
|
After these changes are made, LGTM. |
|
This implements #2985 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.