This repository was archived by the owner on Jul 29, 2024. It is now read-only.
fix(ci): Log test output on CircleCI #3882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The circle ci output is really long now and hard to skim, especially because of the failure tests. I would rather see each line of output replaces with a |
heathkit
force-pushed
the
show-stdio-ci
branch
from
79b64b2 to
dbe0257
Compare
heathkit
changed the title
|
I changed it to dots and also saved the test output as a build artifact. I'm hoping this will help debug the intermittent timeouts we're seeing for the beta branch, which I'm thinking are due to a problem with Blocking Proxy and alert handling. |
sjelin
reviewed
Dec 28, 2016
sjelin
approved these changes
Dec 28, 2016
heathkit
force-pushed
the
show-stdio-ci
branch
from
01a8545 to
007f845
Compare
heathkit
force-pushed
the
show-stdio-ci
branch
from
007f845 to
daa0577
Compare
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
CircleCI will timeout the test if it doesn't see any output for 10 minutes. This prints out a '.' with every bit of stdio input to show that we're making progress.
Helps with debugging on CircleCI. If the test times out or is killed, we'll be able to see what it was doing. Also removes the unused alwaysEnableStdio() method.
heathkit
force-pushed
the
show-stdio-ci
branch
from
daa0577 to
8beb9ec
Compare
|
Test failure is the javascript dialog problem from chromedriver - going to go ahead and merge. |
juliemr
pushed a commit
that referenced
this pull request
Dec 29, 2016
CircleCI will timeout the test if it doesn't see any output for 10 minutes. This prints out a '.' with every bit of stdio input to show that we're making progress.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI will timeout the test if it doesn't see any output for 10
minutes. When running in CI, we need to inherit stdio so we don't get
killed if the tests run slowly due to timeouts. This will also give us
more info for debugging.