This repository was archived by the owner on Jul 29, 2024. It is now read-only.
rework debugprint to ts #5074
Merged
rework debugprint to ts #5074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cnishina , could you take a look at this PR, please |
|
Reference #5061 |
|
@cnishina any updates? |
cnishina
suggested changes
Dec 17, 2018
| Logger = require('../logger').Logger; | ||
| import * as util from 'util'; | ||
| import {Logger} from '../logger'; | ||
| import {Runner} from '../runner'; | ||
|
|
There was a problem hiding this comment.
`import {RunResults} from '../taskRunner';
We might need to update the RunResults to be more flexible:
https://github.com/angular/protractor/blob/selenium4/lib/taskRunner.ts#L9
export interface RunResults {
taskId?: number;
specs?: Array<string>;
...
lib/frameworks/debugprint.ts
Outdated
| @@ -11,11 +12,9 @@ var logger = new Logger('debugger'); | |||
| * @param {Array} specs Array of Directory Path Strings. | |||
| * @return {Promise} Promise resolved with the test results | |||
| */ | |||
| exports.run = (runner, specs) => { | |||
| export const run = (runner: Runner, specs: Array<string>) => { | |||
There was a problem hiding this comment.
export const run = (runner: Runner, specs: Array<string>): Promise<RunResults> => {
| failedCount: 0 | ||
| }); | ||
| logger.info(`Resolved spec files: ${util.inspect(specs)}`); | ||
| resolve({failedCount: 0}); |
There was a problem hiding this comment.
Once the changes are made to RunResults you probably do not need to cast. If for some reason there are type errors, you might need to cast this to resolve({failedCount: 0} as RunResults);
|
@cnishina I did not update RunResults. Probably, it is not necessary. |
cnishina
approved these changes
Dec 18, 2018
|
Hmmm I guess not. Awesome! |
cnishina
pushed a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
cnishina
pushed a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.