-
Notifications
You must be signed in to change notification settings - Fork 2.3k
typings(selenium): try out new version of typings #5084
Conversation
176b0b4
to
6cc33a2
Compare
This appears to be working. I plan to use these typings in place until we have a selenium-webdriver 4 typings in DefinitelyTyped. |
6cc33a2
to
edf9ca0
Compare
Looks like there are some issues with this. Some incremental fixes are in this PR: #5089 |
edf9ca0
to
de7b9b5
Compare
This will be removed when DefinitelyTyped is updated. |
Can you split the change to jasmine version into a separate PR? Were any changes necessary to the typings? |
I think I changed them by mistake. |
1244125
to
9334b51
Compare
Approved, but I just saw the Travis failure and it looks "interesting" |
92057fa
to
19764a6
Compare
19764a6
to
0e6d775
Compare
The Travis failures are weird. I'm not sure if the Travis failures are based on Travis and Sauce connections. 100% of the time they will pass on Circle and maybe 40% of the time they will pass on Travis + Sauce Labs. I've also noticed that Travis gets a lot of unhandled promise rejections. This is weird. I could maybe throw an exception so it cause a failure. I've tried to inspect the error error, but it isn't very helpful. We can discuss this on Monday. |
There are also a lot of these Travis error messages: "Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received" Maybe we need to adjust our builds to wait more in Travis? Put |
No description provided.