Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

typings(selenium): try out new version of typings #5084

Merged
merged 2 commits into from
Dec 15, 2018

Conversation

cnishina
Copy link
Contributor

No description provided.

@cnishina cnishina force-pushed the new_typings branch 2 times, most recently from 176b0b4 to 6cc33a2 Compare December 12, 2018 01:25
@cnishina cnishina requested a review from heathkit December 12, 2018 01:37
@cnishina
Copy link
Contributor Author

This appears to be working. I plan to use these typings in place until we have a selenium-webdriver 4 typings in DefinitelyTyped.

@cnishina
Copy link
Contributor Author

Looks like there are some issues with this. Some incremental fixes are in this PR: #5089

@cnishina
Copy link
Contributor Author

This will be removed when DefinitelyTyped is updated.

@juliemr
Copy link
Member

juliemr commented Dec 15, 2018

Can you split the change to jasmine version into a separate PR?

Were any changes necessary to the typings?

@cnishina
Copy link
Contributor Author

I think I changed them by mistake.

@cnishina cnishina requested a review from juliemr December 15, 2018 01:17
@heathkit
Copy link
Contributor

Approved, but I just saw the Travis failure and it looks "interesting"

@cnishina cnishina merged commit 67b3dba into angular:selenium4 Dec 15, 2018
@cnishina
Copy link
Contributor Author

The Travis failures are weird. I'm not sure if the Travis failures are based on Travis and Sauce connections. 100% of the time they will pass on Circle and maybe 40% of the time they will pass on Travis + Sauce Labs.

I've also noticed that Travis gets a lot of unhandled promise rejections. This is weird. I could maybe throw an exception so it cause a failure. I've tried to inspect the error error, but it isn't very helpful. We can discuss this on Monday.

@cnishina
Copy link
Contributor Author

There are also a lot of these Travis error messages: "Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received"

Maybe we need to adjust our builds to wait more in Travis? Put travis_wait in front of every statement and hope for the best? Instead of wrapping the entire test.js as one node process, maybe each test is kicked of as a separate travis command so the wait is not 20+ minutes for one node process to complete.

cnishina added a commit to cnishina/protractor that referenced this pull request Dec 19, 2018
cnishina added a commit to cnishina/protractor that referenced this pull request Mar 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants