This repository was archived by the owner on Jul 29, 2024. It is now read-only.
feat(jasminewd): Return promise from wrapped matcher #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated CLA checker says: please sign CLA at http://code.google.com/legal/individual-cla-v1.0.html Please make sure that the email associated with your PR is the same as the email you use to sign. |
- Allows you to call done from the last expect in an asynchronous test
- Example
expect(browser.isElementPresent(by.css('SELECTOR')).toBe(true).then(done);
|
Ah this thing. I should have already signed this thing with my other email. Tried filter-branching and force pushing the branch to change the author email. Do I pass the test now? |
|
CLA signature found, thank you! |
|
What does this fix or enable? |
|
Is this trying to achieve something like this? |
|
I think this is trying to do the same thing as #704. Please open a new pull request if there is another reason to do this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expect(browser.isElementPresent(by.css('SELECTOR')).toBe(true).then(done);