This repository was archived by the owner on Jul 29, 2024. It is now read-only.
feat(addMockModule): add third parameter to pass context #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Protractor’s 'addMockModule' method to pass context to its mocks, providing an argument to the script which overrides a module. Rely on the WebDriver’s 'executeScript' method. Closes angular#695
|
Automated CLA checker says: please sign CLA at http://code.google.com/legal/individual-cla-v1.0.html Please make sure that the email associated with your PR is the same as the email you use to sign. |
|
Signed! Thank you. |
|
CLA signature found, thank you! |
| @@ -837,10 +839,13 @@ Protractor.prototype.isElementPresent = function(locatorOrElement, varArgs) { | |||
| * | |||
| * @param {!string} name The name of the module to load or override. | |||
| * @param {!string|Function} script The JavaScript to load the module. | |||
| * @param {*=} argument The argument provided to the script as | |||
| * `arguments[0]`. | |||
There was a problem hiding this comment.
It would be neat if this supported full var_args so you could pass more than one argument.
There was a problem hiding this comment.
Sure, we could use this.moduleArgs_.push(Array.prototype.slice.call(arguments, 2)); there, and something like this.driver.executeScript.apply(null, [this.moduleScripts_[i]].concat(this.moduleArgs_[i])); below. I will test and commit it ASAP.
Allow Protractor’s 'addMockModule' method to pass context to its mocks, providing arguments to the script which overrides a module. Support any arguments provided in addition to the module’s name and script. Those arguments may be referenced from the script via the `arguments` object. Rely on the WebDriver’s 'executeScript' method. Closes angular#695
|
Thanks for the updates! Merged as b7afa87 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Protractor’s 'addMockModule' method to pass context to its mocks,
providing an argument to the script which overrides a module.
Rely on the WebDriver’s 'executeScript' method.
Closes #695