Translate require/export to goog.module equivalents #111
Comments
|
+1. |
evmar
added a commit
that referenced
this issue
Mar 29, 2016
Summary: Sickle now processes "export *" at input type, before JS emit. If we end up generating JS that uses __export(), we've already lost, because Closure doesn't know about the types of all the exported variables. Part of issue #111. Reviewers: rkirov, alexeagle Reviewed By: alexeagle Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D32
evmar
added a commit
that referenced
this issue
Apr 6, 2016
Summary: The superclass "Rewriter" manages the AST traversal and node emitting, while Annotator then implements a node-visit function and handles all the same logic it did before. This split is so we can use the Rewriter logic a second time, in the module rewriter (the piece that processes JS->JS to inject goog.module etc.). More work to prepare for #111. Reviewers: rkirov, mprobst Reviewed By: mprobst Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D41
evmar
added a commit
that referenced
this issue
Apr 8, 2016
Summary: The bug was that we'd look for the first statement before producing a goog.module, so if the file had no statements we wouldn't produce one. The code looked like it was trying to be clever and emit the goog.module after an initial file comment, but it didn't actually work. Do the simpler equivalent thing for now. More work on #111. Reviewers: alexeagle Reviewed By: alexeagle Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D58
evmar
added a commit
that referenced
this issue
Apr 8, 2016
Summary: The convertCommonJsToGoogModule API returned a referencedModules array, but it was always empty(!). Actually return the referenced modules. More work on issue #111. Reviewers: alexeagle Reviewed By: alexeagle Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To run sickle by itself, we need to translate the emitted
require("foo")statements intogoog.requirecalls.This basically means move
convertCommonJsToGoogModulefrom Google internal to sickle repo, which is likely where it belonged in the first place.The text was updated successfully, but these errors were encountered: