-
Notifications
You must be signed in to change notification settings - Fork 681
feat(http): add transfer cache module from nguniversal/common #510
Conversation
Looks good aside from the linting changes, revert those for now. |
@Toxicable on it! |
#511 created to deal with linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 👍
I think it would be good if you can provide an example of it too
Maybe a new component for HTTP request representing and how does cache work.
@Toxicable thoughts on @m98's comments? Personally I don't see the usefulness of giving an example for @m98 I still think it would be invaluable if you could provide another example to the repo for demonstrating usage of the |
I did not mean adding an example to demonstrating usage of the But since this pull request adds ability to transfer state from server to browser, it might be helpful to use a simple HTTP request just let users know there is already something which is supporting transfer state. They might write their own services to support this if they don't know such thing added to the repo |
I think adding an example for each would be the better path for this one, so that we can compare and show the different situations you'd use either |
.gitignore
Outdated
@@ -2,6 +2,7 @@ | |||
.DS_Store | |||
.vscode | |||
morgan.log | |||
package-lock.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhhhh we shouldn't be ignoring this file.
We should either use Yarn or Npm and stick to just one.
I vote Yarn :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
package.json
Outdated
"@nguniversal/express-engine": "^5.0.0-beta.5", | ||
"@nguniversal/module-map-ngfactory-loader": "^5.0.0-beta.5", | ||
"core-js": "^2.4.1", | ||
"rxjs": "^5.5.2", | ||
"rxjs": "^5.5.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is unneeded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
* Adds TransferHttpCacheModule from nguniversal/common to avoid duplicate HTTP calls between server and browser * Bump RxJS dep to 5.5.5 to avoid issues with lower patch versions
duplicate HTTP calls between server and browser
PR close #509