Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

fix(aspnetcore-engine): fix ServerTransferStateModule and TransferState #889

Merged

Conversation

stephenlautier
Copy link
Contributor

  • Please check if the PR fulfills these requirements
- [x] The commit message follows our guidelines: https://github.com/angular/universal/blob/master/CONTRIBUTING.md#commit-message-format
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
  • What modules are related to this pull-request
- [x] aspnetcore-engine
- [ ] express-engine
- [ ] hapi-engine
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix the ability to use TransferState and ServerTransferStateModule

  • What is the current behavior? (You can also link to an open issue here)
    When using ServerTransferStateModule it was breaking html from being rendered on the server.

  • What is the new behavior (if this is a feature change)?
    ServerTransferStateModule now work out of the box, and also returning the moduleRef which consumers can use to do some other logic with their services before transferring it to .net.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No breaking changes have been done, unless for some reason the consumer was using directly UniversalData.title (which is not even exposed)

  • Other information:

@Flood
Copy link

Flood commented Feb 7, 2018

Great job Stephen!

@MarkPieszak
Copy link
Contributor

This looks great Stephen! @stephenlautier
How come we need platform-server-utils, is this temporary until we get an actual fix into Core itself there?

Copy link
Contributor

@MarkPieszak MarkPieszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenlautier
Copy link
Contributor Author

@MarkPieszak I needed that to return the moduleRef to get the injector from it, ideally its just temp and it will be done in angular/platform-server i had opened an issue angular/angular#22049

Unfortunately, I had never contributed to it, its quite complex, and I use windows some tooling doesn't seems to work well.

If anyone can help on that issue, it would be awesome!

@CaerusKaru CaerusKaru added pr_state: LGTM action: merge PR author is ready for this to merge and removed action: merge PR author is ready for this to merge labels Feb 13, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge PR author is ready for this to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants