Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

addEventListener in strict mode #190

Closed
vicb opened this issue Oct 6, 2015 · 0 comments · Fixed by #191
Closed

addEventListener in strict mode #190

vicb opened this issue Oct 6, 2015 · 0 comments · Fixed by #191

Comments

@vicb
Copy link
Contributor

vicb commented Oct 6, 2015

When addEventListener is called in strict mode, var target = isWebWorker() && !this ? self : this would evaluate to undefined in patchEventTargetMethods() resulting in an error.

Notes:

  • in non strict mode, this would be set to window and there would be no error,
  • window.addEventListener() would work in both strict & non-strict mode.

/ref angular/angular#4531
vicb added a commit to vicb/zone.js that referenced this issue Oct 6, 2015
@vicb
fix(addEventListener): when called from the global scope
bd815a7 
fixes angular#190
@vicb vicb mentioned this issue Oct 6, 2015
Merged
vicb added a commit to vicb/zone.js that referenced this issue Oct 6, 2015
@vicb
fix(addEventListener): when called from the global scope
8e90e24 
fixes angular#190
vicb added a commit to vicb/zone.js that referenced this issue Oct 6, 2015
@vicb
fix(addEventListener): when called from the global scope
7e6dfa3 
fixes angular#190
vicb added a commit to vicb/zone.js that referenced this issue Oct 6, 2015
@vicb
fix(addEventListener): when called from the global scope
a23d61a 
fixes angular#190
@vicb vicb closed this as completed in #191 Oct 6, 2015
@xtianus79 xtianus79 mentioned this issue Jan 25, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(addEventListener): when called from the global scope vicb/zone.js
1 participant
@vicb