-
Notifications
You must be signed in to change notification settings - Fork 408
Zone.js browser bundle pollutes global namespace #456
Comments
We're also seeing this issue causing problems with Protractor since we rely on window.name there as well. |
See also #452 |
@juliemr this is, indeed a duplicate. Sorry about that. Feel free to close one and track it one place or the other. |
I think this one is more general, I'll close the other. |
I'm pretty sure this was due to the swap from webpack to rollup for bundling. The suggested fix is to go back to having everything execute in a closure, I'm trying to figure out how to do that with rollup. |
This means that we will stop polluting the global namespace when zone.js is included. Fixes angular#456
This means that we will stop polluting the global namespace when zone.js is included. Fixes angular#456
This means that we will stop polluting the global namespace when zone.js is included. Fixes #456
This is now fixed in the latest release. |
Awesome, this also fixed my problem: I had an error message of |
The
browser.ts
file (https://github.com/angular/zone.js/blob/master/lib/browser/browser.ts) is not being bundled inside any closure, resulting in all of its top-level functions and variables becoming globals.This was discovered because this behaviour was breaking Plunker's preview by overriding
window.name
toalert
. Down the rabbit hole we go and find ourselves here.The text was updated successfully, but these errors were encountered: