Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

readonly property should not be patched in patchMethod in v0.8.16 #869

Closed
manugarciac opened this issue Aug 7, 2017 · 6 comments · Fixed by #871
Closed

readonly property should not be patched in patchMethod in v0.8.16 #869

manugarciac opened this issue Aug 7, 2017 · 6 comments · Fixed by #871

Comments

@manugarciac
Copy link

manugarciac commented Aug 7, 2017

I'm getting the error while testing my application on Safari. It is fixed if I comment this lines (lines 1226 to 1228):

    proto[name] = function () {
        return patchDelegate_1(this, arguments);
    };

Inside function patchMethod(target, name, patchFn).

Could you please check it out?

Thank you

@JiaLiPassion
Copy link
Collaborator

JiaLiPassion commented Aug 7, 2017

@manugarciac , could you check the attached zip, if it works, please wait for the next release.
https://github.com/angular/zone.js/files/1185784/zone.js.zip

@BillyQin
Copy link

BillyQin commented Aug 8, 2017

@manugarciac @JiaLiPassion It works. i am wait for the next release

@manugarciac
Copy link
Author

@JiaLiPassion That is the same file from this issue, right?

#859 (comment)

I had already tested it with that before opening my issue, and no, it doesn't work.

@BillyQin What do you mean? The zip works for you?

@JiaLiPassion
Copy link
Collaborator

@manugarciac , yes, it is the same file, so could you provide a reproduce repo?

@manugarciac
Copy link
Author

@JiaLiPassion Here you go:

https://github.com/manugarciac/safari-error-app

You can do npm install and then ng serve to test it. The page loads, but the error is there. I start it like this: ng serve --host 0.0.0.0 --disable-host-check so that I can test it on another PC with Safari (I don't have Safari on my own PC).

@JiaLiPassion
Copy link
Collaborator

@manugarciac , thank you, I will fix this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants