This repository was archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can you resolve this? |
@mhevery , this PR is not finished, I want to confirm that if we add
will become
so should I do it now? it may have impact to |
Yes we should do this. If angular changes will update...
…On Tue, Mar 13, 2018 at 8:24 PM, JiaLiPassion ***@***.***> wrote:
@mhevery <https://github.com/mhevery> , this PR is not finished, I want
to confirm that if we add strict : true, some API may changes (add
optional ? or add | null type definition) such as
scheduleMacroTask(
source: string, callback: Function, data: TaskData, customSchedule: (task: Task) => void,
customCancel: (task: Task) => void): MacroTask;
will become
scheduleMacroTask(
source: string, callback: Function, data?: TaskData, customSchedule?: (task: Task) => void,
customCancel?: (task: Task) => void): MacroTask;
so should I do it now? it may have impact to angular
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1044 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAG1T62heNqX8xs_cNQksr5quwvIL9oXks5teI2BgaJpZM4SlVgT>
.
|
@mhevery , got it, I will continue to finish this one. |
945eb1a
to
2458147
Compare
2458147
to
3d97af3
Compare
@mhevery , I have finished this one and resolved the conflicts, the CI is red because of |
3d97af3
to
8ddef96
Compare
mhevery
approved these changes
Jun 18, 2018
JiaLiPassion
added a commit
to JiaLiPassion/angular
that referenced
this pull request
Jan 24, 2019
1. Update zone.js to 0.8.29 2. Because zone.js angular/zone.js#1044 use `strict:true` in tsconfig, so some of the API of Zone change. Such as `Zone.parent` will return `Zone | null` instead of `Zone`, so several usage need to be updated in `angular` side too. 3. Also because zone.js add some new patch (fetch/customElement), the size of polyfill increases a little
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change
tsconfig.json
There are a lot of
null
error, and current this PR isWIP
, to make it compilable, we need to modify someinterface
such asZone.current
,Zone.currentTask
,Zone.scheduleMacroTask
,ZoneSpec.onXXX
because they all may return null or undefined.@mhevery , do you think we should do this now? it will have breaking change to
zone API
and may affectangular
. please review, thank you.