feat: Add a zone spec for fake async test zone. #330

vikerman · 2016-04-18T21:39:42Z

This implementation is forked from the fake async from Angular 2 and adds the following

Implements own scheduler queue that doesn't depend on the jasmine implementation of a scheduler queue.
Handles errors in timer/microtask callbacks better so that pending timers are removed properly on error (No need for a clearPendingTimers at the end of a test handling errors). The queue processing is stopped after the first error and can be restarted.
Throw an exception if a XMLHttpRequest is used in a fakeAsync test - Useful for avoiding cases for ex. someone uses the online template compiler in a fakeAsync test but forgot to use the template cache and ends up doing a XHR in the test.

juliemr · 2016-04-18T23:42:27Z

The Travis error seems to be legitimate.

juliemr · 2016-04-18T23:56:13Z

test/zone-spec/fake-async-test.spec.ts

+
+        setTimeout(() => log.push('timer'), 9);
+
+        let id = setInterval(() => log.push('periodic timer'), 10);


id is unused

juliemr · 2016-04-19T00:43:19Z

Looks good overall!

vikerman · 2016-04-19T03:35:06Z

Travis error - I need a better way to check whether the macro task is a XHR related call.

vikerman assigned mhevery Apr 18, 2016

juliemr reviewed Apr 18, 2016
View reviewed changes

vikerman force-pushed the fake_async branch from b5b24d4 to 6ddd514 Compare April 19, 2016 03:58

feat: Add a zone spec for fake async test zone.

6687cee

vikerman force-pushed the fake_async branch from 9350b7b to 6687cee Compare April 19, 2016 21:52

juliemr merged commit 34159b4 into angular:master Apr 19, 2016

Provide feedback


		setTimeout(() => log.push('timer'), 9);

		let id = setInterval(() => log.push('periodic timer'), 10);