Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

(updated) fix: commonjs wrapper #73

Closed
wants to merge 3 commits into from

Conversation

unframework
Copy link
Contributor

This is a rebase and tweak of original commonjs wrapper fix: #22

Closes #19

@btford
Copy link
Contributor

btford commented Apr 8, 2015

It'd be nice to have a test showing that this works.

@unframework
Copy link
Contributor Author

@btford thanks for the response! I just added a test using karma-browserify; also had to tweak the original implementation because it inadvertently masked original window reference for property patching.

@unframework
Copy link
Contributor Author

... not sure if the test failures were there from before - the code seems to work OK in my local browserify setup in Chrome and FF.

@unframework
Copy link
Contributor Author

I created a temp npm package to be able to reference this as a dependency. Will remove once merged.

@btford
Copy link
Contributor

btford commented Apr 10, 2015

@unframework – FYI you can npm install unframework/zone.js and npm will grab your stuff from github. It's better not to pollute the npm namespace, even if only temporarily.

@unframework
Copy link
Contributor Author

Hey thanks for the tip, I forgot about that package.json feature. Removed the temp package, using the Git dependency now

@btford
Copy link
Contributor

btford commented Apr 10, 2015

Landed as 5d6bee4.

I'll cut a release with this sometime soon.

@btford btford closed this Apr 10, 2015
@ocombe
Copy link
Contributor

ocombe commented Apr 13, 2015

Ahh nice, waiting for this release as well :)

@ocombe
Copy link
Contributor

ocombe commented Apr 13, 2015

By the way, you'll have to edit the following file https://github.com/angular/angular/blob/master/modules/angular2/src/core/zone/vm_turn_zone.es6 to make it work with your changes (you probably know that already), I tested it locally and it works with webpack now (I edited this file from angular2 to test)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not seem to be browserify compatible
3 participants