-
Notifications
You must be signed in to change notification settings - Fork 408
Conversation
It'd be nice to have a test showing that this works. |
@btford thanks for the response! I just added a test using karma-browserify; also had to tweak the original implementation because it inadvertently masked original window reference for property patching. |
... not sure if the test failures were there from before - the code seems to work OK in my local browserify setup in Chrome and FF. |
I created a temp npm package to be able to reference this as a dependency. Will remove once merged. |
@unframework – FYI you can |
Hey thanks for the tip, I forgot about that |
Landed as 5d6bee4. I'll cut a release with this sometime soon. |
Ahh nice, waiting for this release as well :) |
By the way, you'll have to edit the following file https://github.com/angular/angular/blob/master/modules/angular2/src/core/zone/vm_turn_zone.es6 to make it work with your changes (you probably know that already), I tested it locally and it works with webpack now (I edited this file from angular2 to test) |
This is a rebase and tweak of original commonjs wrapper fix: #22
Closes #19