Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

fix(console): console.log in nodejs should run in root Zone #855

Merged
merged 1 commit into from
Jul 27, 2017
Merged

fix(console): console.log in nodejs should run in root Zone #855

merged 1 commit into from
Jul 27, 2017

Conversation

JiaLiPassion
Copy link
Collaborator

fix angular/angular#17180

in nodejs, console.log will use process.nextTick and schedule a microTask which will cause
infinite loop, so we need to make sure it run in Zone.root.

@JiaLiPassion JiaLiPassion mentioned this pull request Jul 25, 2017
Closed
@vikerman
Copy link
Contributor

Thanks! LGTM

@mhevery mhevery merged commit 5900d3a into angular:master Jul 27, 2017
@JiaLiPassion JiaLiPassion deleted the consolelog branch August 10, 2017 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vikerman vikerman vikerman approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
4 participants
@JiaLiPassion @vikerman @mhevery @googlebot