Skip to content

fix: cleanup autoapi templates using macros #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 23, 2024
Merged

fix: cleanup autoapi templates using macros #556

merged 21 commits into from
Oct 23, 2024

Conversation

Revathyvenugopal162
Copy link
Contributor

fix #533

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Oct 17, 2024
@jorgepiloto jorgepiloto added this to the v1.2 milestone Oct 18, 2024
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review October 18, 2024 09:45
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner October 18, 2024 09:45
@jorgepiloto
Copy link
Member

Checking with the artifacts.

@jorgepiloto
Copy link
Member

All working good. I was afraid about the indentation causing some problems but that's not the case.

@jorgepiloto jorgepiloto added fix Pull requests related to resolving problems or errors and removed bug Defects or glitches reported by users or developers labels Oct 18, 2024
jorgepiloto
jorgepiloto requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to adapt the order and the number of arguments passed when calling the functions.

@jorgepiloto jorgepiloto merged commit ff89444 into main Oct 23, 2024
21 checks passed
@jorgepiloto jorgepiloto deleted the fix/marcros-jinja branch October 23, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

Assignees
No one assigned
Labels
fix Pull requests related to resolving problems or errors
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Use Jinja macros in autoapi.rst file for customization
3 participants
@Revathyvenugopal162 @jorgepiloto @pyansys-ci-bot