Skip to content

NamedSelection class should contain the members of the Named Selection #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Alberto-DM opened this issue Apr 5, 2024 · 4 comments · Fixed by #1768
Closed

NamedSelection class should contain the members of the Named Selection #1101

Alberto-DM opened this issue Apr 5, 2024 · 4 comments · Fixed by #1768
Assignees
Labels
enhancement New features or code improvements PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog SERVER-IMPLEMENTATION Issue/PR assigned with this tag must be solved server-side

Comments

@Alberto-DM
Copy link

📝 Description of the feature

Currently, it's not possible to retrieve the bodies and components belonging to a Named Selection.
NamedSelection class only has 2 properties: id and name.
It would be useful to have a members property returning a list of the members belonging to the NS itself.
It would be even more useful if the object is returned rather than just the body/component id.

💡 Steps for implementing the feature

No response

🔗 Useful links and references

No response

@Alberto-DM Alberto-DM added the enhancement New features or code improvements label Apr 5, 2024
@RobPasMue
Copy link
Member

This one is actually a pretty good idea. Let me think about how to implement it properly.

@RobPasMue
Copy link
Member

So...

Right now, if the named selection is created through PyAnsys Geometry, this would be easy to implement. But you already need to pass the elements when creating the named selection, so it is not that "useful" I'd say - you already know which elements you used to create the named selection. Nonetheless, it could be implemented.

The problem comes if we are reading an existing design from the service. In that case, we need to implement the capability in the service to return the elements that make the named selection.

The backend team is going to open a user story to track this work.

@Alberto-DM
Copy link
Author

Thanks for the update.

@RobPasMue RobPasMue added PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog SERVER-IMPLEMENTATION Issue/PR assigned with this tag must be solved server-side labels Aug 30, 2024
@RobPasMue RobPasMue linked a pull request Feb 27, 2025 that will close this issue
9 tasks
@RobPasMue
Copy link
Member

#1768 will close this task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog SERVER-IMPLEMENTATION Issue/PR assigned with this tag must be solved server-side
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants