feat: named selection functionality #1768

jacobrkerstetter · 2025-02-21T19:05:21Z

Description

move_rotate / move_translate implemented to transform named selections
enhanced reading existing designs to take more information from named selections
enhanced creating new name selections from client-side designs

Issue linked

Checklist

I have tested my changes locally.
I have added necessary documentation or updated existing documentation.
I have followed the coding style guidelines of this project.
I have added appropriate unit tests.
I have reviewed my changes before submitting this pull request.
I have linked the issue or issues that are solved to the PR if any.
I have assigned this PR to myself.
I have added the minimum version decorator to any new backend method implemented.
I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

need read existing design functionality

implemented MoveRotate and MoveTranslate for named selections

src/ansys/geometry/core/designer/design.py

- fixed logic for creating new NS so the create command is only called once

…om/ansys/pyansys-geometry into feat/named_selection_functionality

- added more rigorous testing by querying a face for area - altered how the face/body/edge objects are populated for NS

…om/ansys/pyansys-geometry into feat/named_selection_functionality

…dges in a dict

codecov · 2025-02-26T20:34:20Z

Codecov Report

Attention: Patch coverage is 88.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.90%. Comparing base (1cf0733) to head (41ad431).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/ansys/geometry/core/designer/selection.py	75.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1768      +/-   ##
==========================================
+ Coverage   90.88%   90.90%   +0.02%     
==========================================
  Files          92       92              
  Lines        8357     8422      +65     
==========================================
+ Hits         7595     7656      +61     
- Misses        762      766       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RobPasMue

This is looking really good! Left some comments, request review again once addressed

src/ansys/geometry/core/designer/design.py

src/ansys/geometry/core/designer/selection.py

tests/integration/files/combustor_fluid_volume.scdocx

src/ansys/geometry/core/designer/geometry_commands.py

- adjusted import test for new model - added Quantity input type for new geometry commands - adjusted NamedSelection constructor -- beams still a question

…om/ansys/pyansys-geometry into feat/named_selection_functionality

RobPasMue

LGTM!

jkerstet added 4 commits February 18, 2025 11:26

added properties

bd9e051

need read existing design functionality

tested named selection import

da25a31

able to query named_selections for underlying members

ef8b880

implemented named selection from existing design

2b9b695

implemented MoveRotate and MoveTranslate for named selections

jacobrkerstetter self-assigned this Feb 21, 2025

jacobrkerstetter changed the title ~~feat: Named Selection Functionality~~ feat: named selection functionality Feb 21, 2025

Merge branch 'main' into feat/named_selection_functionality

302cda6

github-actions bot added the enhancement New features or code improvements label Feb 21, 2025

pyansys-ci-bot and others added 3 commits February 21, 2025 19:07

chore: adding changelog file 1768.added.md [dependabot-skip]

9848969

chore: auto fixes from pre-commit hooks

e285344

change repeated selection field to single named selection

ba51faa

jacobrkerstetter marked this pull request as ready for review February 24, 2025 16:20

jacobrkerstetter requested a review from a team as a code owner February 24, 2025 16:20

Merge branch 'main' into feat/named_selection_functionality

2224804

jacobrkerstetter requested review from RobPasMue and jonahrb February 24, 2025 16:23

RobPasMue requested changes Feb 25, 2025

View reviewed changes

src/ansys/geometry/core/designer/design.py Outdated Show resolved Hide resolved

src/ansys/geometry/core/designer/design.py Show resolved Hide resolved

jkerstet and others added 13 commits February 25, 2025 09:17

- fixed move_rotate and move_translate proto naming

a8ff440

- fixed logic for creating new NS so the create command is only called once

chore: auto fixes from pre-commit hooks

a2cc30f

Merge branch 'main' into feat/named_selection_functionality

04af7d0

edited test because order of id's is not constant

6d9b804

Merge branch 'feat/named_selection_functionality' of https://github.c…

3768b9c

…om/ansys/pyansys-geometry into feat/named_selection_functionality

- removed a few NS from the test file for speed of testing

18b358a

- added more rigorous testing by querying a face for area - altered how the face/body/edge objects are populated for NS

Merge branch 'main' into feat/named_selection_functionality

ff262a9

chore: auto fixes from pre-commit hooks

e9647ff

precommit fix

cb3ecc7

merge error fix

999cc3f

accepting distance object for offset_faces_set_radius

00e433d

updated docstring

ebbe4cb

chore: auto fixes from pre-commit hooks

ed0383a

jkerstet added 3 commits February 26, 2025 11:53

accept Beam from NamedSelection constructor

f59a2c7

Merge branch 'feat/named_selection_functionality' of https://github.c…

a0a985f

…om/ansys/pyansys-geometry into feat/named_selection_functionality

enhanced result from move rotate to include modified bodies, faces, e…

c0216a1

…dges in a dict

Merge branch 'main' into feat/named_selection_functionality

afd1e8a

RobPasMue reviewed Feb 27, 2025

View reviewed changes

RobPasMue linked an issue Feb 27, 2025 that may be closed by this pull request

NamedSelection class should contain the members of the Named Selection #1101

Closed

RobPasMue mentioned this pull request Feb 27, 2025

NamedSelection class should contain the members of the Named Selection #1101

Closed

jkerstet and others added 7 commits February 27, 2025 10:56

- edited model

1558093

- adjusted import test for new model - added Quantity input type for new geometry commands - adjusted NamedSelection constructor -- beams still a question

Merge branch 'feat/named_selection_functionality' of https://github.c…

adf96d6

…om/ansys/pyansys-geometry into feat/named_selection_functionality

chore: auto fixes from pre-commit hooks

fc53f96

Merge branch 'main' into feat/named_selection_functionality

b8e838f

removed beams from reading existing design (not supported yet)

6f787c9

chore: auto fixes from pre-commit hooks

d899975

Merge branch 'main' into feat/named_selection_functionality

41ad431

RobPasMue approved these changes Feb 28, 2025

View reviewed changes

jacobrkerstetter merged commit 481ef66 into main Feb 28, 2025
52 checks passed

jacobrkerstetter deleted the feat/named_selection_functionality branch February 28, 2025 16:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: named selection functionality #1768

feat: named selection functionality #1768

Uh oh!

jacobrkerstetter commented Feb 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 26, 2025 •

edited

Loading

Uh oh!

RobPasMue left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RobPasMue left a comment

Uh oh!

Uh oh!

Uh oh!

feat: named selection functionality #1768

feat: named selection functionality #1768

Uh oh!

Conversation

jacobrkerstetter commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue linked

Checklist

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

RobPasMue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RobPasMue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jacobrkerstetter commented Feb 21, 2025 •

edited

Loading

codecov bot commented Feb 26, 2025 •

edited

Loading