Skip to content

feat: default logs folder on Geometry Service started by Python at PUBLIC (Windows) #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

RobPasMue
Copy link
Member

Description

Whenever we launch the Geometry Service locally (on Windows), we will make use of the APPDATA directory for Ansys products. Users should always have write permissions to it, and it will prevent from having some common issues like #1374 (reply in thread)

Issue linked

Closes #1377

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Aug 29, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner August 29, 2024 14:50
@github-actions github-actions bot added the enhancement New features or code improvements label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.79%. Comparing base (1def483) to head (e98ce9e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ansys/geometry/core/connection/product_instance.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1386      +/-   ##
==========================================
- Coverage   91.87%   91.79%   -0.08%     
==========================================
  Files          86       86              
  Lines        6792     6802      +10     
==========================================
+ Hits         6240     6244       +4     
- Misses        552      558       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we raise an exception in case the user does not have permissions for APPDATA?
It happens quite often.

@RobPasMue
Copy link
Member Author

Should we raise an exception in case the user does not have permissions for APPDATA? It happens quite often.

Well.. That's a good point. We could check whether a user has write access to the folder even before starting (in case it is provided). And if not, we throw an error. Let me check that anyway :)

@RobPasMue RobPasMue changed the title feat: logs on Geometry Service started by Python client always on specific dir at APPDATA (Windows) feat: default logs folder on Geometry Service started by Python at PUBLIC (Windows) Aug 30, 2024
@RobPasMue RobPasMue merged commit 9a93725 into main Aug 30, 2024
43 checks passed
@RobPasMue RobPasMue deleted the feat/use-app-data-logs branch August 30, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform logging in PUBLIC folder rather than the products folder
3 participants