-
Notifications
You must be signed in to change notification settings - Fork 17
feat: default logs folder on Geometry Service started by Python at PUBLIC (Windows) #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cific dir at APPDATA (Windows)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
==========================================
- Coverage 91.87% 91.79% -0.08%
==========================================
Files 86 86
Lines 6792 6802 +10
==========================================
+ Hits 6240 6244 +4
- Misses 552 558 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we raise an exception in case the user does not have permissions for APPDATA?
It happens quite often.
Well.. That's a good point. We could check whether a user has write access to the folder even before starting (in case it is provided). And if not, we throw an error. Let me check that anyway :) |
Description
Whenever we launch the Geometry Service locally (on Windows), we will make use of the APPDATA directory for Ansys products. Users should always have write permissions to it, and it will prevent from having some common issues like #1374 (reply in thread)
Issue linked
Closes #1377
Checklist
feat: extrude circle to cylinder
)