Skip to content

feat: imprint curves without a sketch #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 10, 2025
Merged

Conversation

umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Feb 26, 2025

Description

An attempt to overload imprint curves with passing curves directly. See issue linked. Current imprint curves is taking a sketch to get the curves that is needed for backend but apparently that is found limiting for use cases where curves are coming from a set of edges that is not part of the sketch. To serve this need along with other possible usages, we can directly take TrimmedCurve object on client side, and pass it to backend. This PR tries to expose it without breaking the existing use case by overloading it.

image

Issue linked

#1780

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@umutsoysalansys umutsoysalansys requested a review from a team as a code owner February 26, 2025 14:03
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 26, 2025
@umutsoysalansys umutsoysalansys changed the title Feat/imprint curves with edges feat: imprint curves with edges Feb 26, 2025
@umutsoysalansys umutsoysalansys self-assigned this Feb 26, 2025
@umutsoysalansys
Copy link
Contributor Author

@RobPasMue, please see above and let us know if there is a more preferred way of overloading the method.

@umutsoysalansys umutsoysalansys changed the title feat: imprint curves with edges feat: imprint curves without a sketch Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.58%. Comparing base (3bef736) to head (2cbca98).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/body.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
- Coverage   90.60%   90.58%   -0.02%     
==========================================
  Files          92       92              
  Lines        8474     8480       +6     
==========================================
+ Hits         7678     7682       +4     
- Misses        796      798       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rmanno91
rmanno91 previously approved these changes Feb 26, 2025
@RobPasMue RobPasMue linked an issue Feb 26, 2025 that may be closed by this pull request
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good @umutsoysalansys - please handle properly the backwards compatibility inside the method. Once that's done, it's good to go on my side. Request review again once addressed.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - let's merge, thanks @umutsoysalansys

@RobPasMue RobPasMue enabled auto-merge (squash) March 10, 2025 14:44
@RobPasMue RobPasMue merged commit 8091750 into main Mar 10, 2025
45 of 48 checks passed
@RobPasMue RobPasMue deleted the feat/imprint_curves_with_edges branch March 10, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable the possibility to imprint bodies using a list of edges
4 participants