-
Notifications
You must be signed in to change notification settings - Fork 17
feat: imprint curves without a sketch #1781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@RobPasMue, please see above and let us know if there is a more preferred way of overloading the method. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
- Coverage 90.60% 90.58% -0.02%
==========================================
Files 92 92
Lines 8474 8480 +6
==========================================
+ Hits 7678 7682 +4
- Misses 796 798 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good @umutsoysalansys - please handle properly the backwards compatibility inside the method. Once that's done, it's good to go on my side. Request review again once addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good - let's merge, thanks @umutsoysalansys
Description
An attempt to overload imprint curves with passing curves directly. See issue linked. Current imprint curves is taking a sketch to get the curves that is needed for backend but apparently that is found limiting for use cases where curves are coming from a set of edges that is not part of the sketch. To serve this need along with other possible usages, we can directly take TrimmedCurve object on client side, and pass it to backend. This PR tries to expose it without breaking the existing use case by overloading it.
Issue linked
#1780
Checklist
feat: extrude circle to cylinder
)