Skip to content

fix: flaky color test due to random face assignment #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2025
Merged

fix: flaky color test due to random face assignment #1794

merged 3 commits into from
Mar 4, 2025

Conversation

RobPasMue
Copy link
Member

Description

Flaky test due to face color assignment by order on list retrieval. This fixes it by looking at the normal of the face.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Mar 4, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner March 4, 2025 09:04
@github-actions github-actions bot added the bug Something isn't working label Mar 4, 2025
MaxJPRey
MaxJPRey previously approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RobPasMue RobPasMue changed the base branch from main to feat/rgba_colors_support March 4, 2025 12:54
@RobPasMue RobPasMue merged commit 8d1d360 into feat/rgba_colors_support Mar 4, 2025
29 of 32 checks passed
@RobPasMue RobPasMue deleted the fix/flaky-color-test branch March 4, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxJPRey MaxJPRey MaxJPRey left review comments

Assignees

@RobPasMue RobPasMue

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobPasMue @MaxJPRey @pyansys-ci-bot