Skip to content

fix: fix parasolid export tests with more precise backend descriptor #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

b-matteo
Copy link
Contributor

@b-matteo b-matteo commented Mar 6, 2025

Use the new precise backend type setting to determine which parasolid extension we should expect as export output

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

use the new precise backend type setting to determine which parasolid extension we should expect as export output
@b-matteo b-matteo added bug Something isn't working testing Anything related to tests labels Mar 6, 2025
@b-matteo b-matteo self-assigned this Mar 6, 2025
@b-matteo b-matteo requested a review from a team as a code owner March 6, 2025 14:12
@github-actions github-actions bot removed the testing Anything related to tests label Mar 6, 2025
RobPasMue
RobPasMue previously approved these changes Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (ec33acc) to head (ebca1f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1802   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files          92       92           
  Lines        8471     8474    +3     
=======================================
+ Hits         7675     7678    +3     
  Misses        796      796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@b-matteo b-matteo merged commit 11ac170 into main Mar 6, 2025
51 checks passed
@b-matteo b-matteo deleted the fix/parasolid_export_tests branch March 6, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants