Skip to content

test: improve share topology test #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

test: improve share topology test #1804

merged 2 commits into from
Mar 7, 2025

Conversation

RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Mar 7, 2025

Description

Improve Share Topology test

Issue linked

Issue 1774.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard self-assigned this Mar 7, 2025
@RyanJWard RyanJWard requested a review from a team as a code owner March 7, 2025 16:00
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (7a41010) to head (8ca4abb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1804   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files          92       92           
  Lines        8474     8474           
=======================================
  Hits         7678     7678           
  Misses        796      796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RyanJWard RyanJWard changed the title Test: improve share topology test test: improve share topology test Mar 7, 2025
@RyanJWard RyanJWard requested a review from craig-connelly March 7, 2025 18:00
Copy link
Contributor

@jonahrb jonahrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahrb jonahrb linked an issue Mar 7, 2025 that may be closed by this pull request
2 tasks
@RyanJWard RyanJWard enabled auto-merge (squash) March 7, 2025 18:28
@RyanJWard RyanJWard merged commit 3bef736 into main Mar 7, 2025
50 of 51 checks passed
@RyanJWard RyanJWard deleted the test/improve_st_test branch March 7, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

share_topology fails to write info when exported to scdocx/stride
3 participants