Skip to content

feat: matrix helper methods #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 11, 2025
Merged

feat: matrix helper methods #1806

merged 22 commits into from
Mar 11, 2025

Conversation

umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Mar 10, 2025

Description

**Matrix operations that needed in Workflows.

Create a matrix from rotation.
Crate a matrix from mapping.
Create a vector from mapping.

**

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the enhancement New features or code improvements label Mar 10, 2025
@RobPasMue RobPasMue changed the title Feat/more matrix support feat: more matrix support Mar 10, 2025
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.63%. Comparing base (7039876) to head (968d4b9).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
src/ansys/geometry/core/math/matrix.py 94.73% 1 Missing ⚠️
src/ansys/geometry/core/math/vector.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1806      +/-   ##
==========================================
+ Coverage   90.62%   90.63%   +0.01%     
==========================================
  Files          92       92              
  Lines        8476     8507      +31     
==========================================
+ Hits         7681     7710      +29     
- Misses        795      797       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the testing Anything related to tests label Mar 10, 2025
@umutsoysalansys umutsoysalansys marked this pull request as ready for review March 10, 2025 20:59
@umutsoysalansys umutsoysalansys requested a review from a team as a code owner March 10, 2025 20:59
@umutsoysalansys umutsoysalansys changed the title feat: more matrix support feat: matrix helper methods Mar 10, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue enabled auto-merge (squash) March 10, 2025 21:33
@RobPasMue RobPasMue merged commit f26f02c into blitz Mar 11, 2025
25 of 29 checks passed
@RobPasMue RobPasMue deleted the feat/more_matrix_support branch March 11, 2025 13:56
RobPasMue added a commit that referenced this pull request Mar 12, 2025
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
RobPasMue added a commit that referenced this pull request Mar 12, 2025
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants