Skip to content

fix: edge start and end were not being mapped correctly #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

RobPasMue
Copy link
Member

Description

Edge start and end values were not being mapped correctly. They should be using the server length when converted.

Issue linked

Closes #1813

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Mar 11, 2025
@github-actions github-actions bot added the bug Something isn't working label Mar 11, 2025
@RobPasMue RobPasMue marked this pull request as ready for review March 11, 2025 20:47
@RobPasMue RobPasMue requested a review from a team as a code owner March 11, 2025 20:47
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.63%. Comparing base (f26f02c) to head (bbe50d8).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
...ansys/geometry/core/shapes/curves/trimmed_curve.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            blitz    #1816   +/-   ##
=======================================
  Coverage   90.63%   90.63%           
=======================================
  Files          92       92           
  Lines        8507     8508    +1     
=======================================
+ Hits         7710     7711    +1     
  Misses        797      797           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue enabled auto-merge (squash) March 11, 2025 21:06
@RobPasMue RobPasMue merged commit 179686b into blitz Mar 11, 2025
26 of 28 checks passed
@RobPasMue RobPasMue deleted the fix/issue-edge-start-end branch March 11, 2025 21:21
@RobPasMue RobPasMue linked an issue Mar 11, 2025 that may be closed by this pull request
2 tasks
RobPasMue added a commit that referenced this pull request Mar 12, 2025
RobPasMue added a commit that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge start and end locations aren't correct when changing Default Units
3 participants