Skip to content

feat: enhanced beam implementation #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Mar 14, 2025
Merged

Conversation

jacobrkerstetter
Copy link
Contributor

Description

  • added beam import from existing design
  • added beam import from existing named selection
  • enhanced beam class to hold more data

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Mar 13, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner March 13, 2025 17:28
@github-actions github-actions bot added the enhancement New features or code improvements label Mar 13, 2025
@jacobrkerstetter jacobrkerstetter changed the base branch from main to blitz March 14, 2025 12:47
@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 14, 2025
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 85.27132% with 19 lines in your changes missing coverage. Please review.

Project coverage is 90.31%. Comparing base (d2b7537) to head (51bc2e5).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/beam.py 81.25% 18 Missing ⚠️
src/ansys/geometry/core/designer/component.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1828      +/-   ##
==========================================
+ Coverage   88.75%   90.31%   +1.55%     
==========================================
  Files          92       92              
  Lines        8603     8727     +124     
==========================================
+ Hits         7636     7882     +246     
+ Misses        967      845     -122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two small comments and good to go!

@RobPasMue RobPasMue enabled auto-merge (squash) March 14, 2025 15:45
@RobPasMue RobPasMue merged commit 6339ea8 into blitz Mar 14, 2025
24 of 25 checks passed
@RobPasMue RobPasMue deleted the feat/enhanced_beam_implementation branch March 14, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants