Skip to content

test: Fix slow tests #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

test: Fix slow tests #1832

merged 2 commits into from
Mar 14, 2025

Conversation

RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Mar 14, 2025

Description

Some tests were running slow, I update the models to improve run times

Issue linked

General test slowness

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard requested a review from a team as a code owner March 14, 2025 15:09
@RyanJWard RyanJWard self-assigned this Mar 14, 2025
Copy link
Contributor

@syscordan syscordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved changes

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @RyanJWard - thanks a lot!!

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (2336977) to head (eade853).
Report is 2 commits behind head on main.

❌ Your project status has failed because the head coverage (88.72%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
+ Coverage   88.71%   88.72%   +0.01%     
==========================================
  Files          92       92              
  Lines        8559     8559              
==========================================
+ Hits         7593     7594       +1     
+ Misses        966      965       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit 1c56f26 into main Mar 14, 2025
47 of 48 checks passed
@RobPasMue RobPasMue deleted the test/fix_slow_tests branch March 14, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants