Skip to content

fix: change Core Service path to executable/DLL after renaming #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 19, 2025

Conversation

RobPasMue
Copy link
Member

Description

Service rename happened before release - no breaking change consequently to previous Ansys releases. Also, DMS will be retired starting on 25R2 and thus it is necessary to handle the fallback to Core Service in case version is 25R2 or above.

Issue linked

Closes #1818

Checklist

  • I have tested my changes locally.
  • I have followed the coding style guidelines of this project.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Mar 16, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner March 16, 2025 17:17
@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Mar 16, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations 1 Medium
Total 1 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@github-actions github-actions bot added the bug Something isn't working label Mar 16, 2025
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 88.55%. Comparing base (6b7844c) to head (dd0bfdc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ansys/geometry/core/connection/product_instance.py 5.00% 19 Missing ⚠️

❌ Your project status has failed because the head coverage (88.55%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1841      +/-   ##
==========================================
- Coverage   88.72%   88.55%   -0.17%     
==========================================
  Files          92       92              
  Lines        8559     8575      +16     
==========================================
  Hits         7594     7594              
- Misses        965      981      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue force-pushed the fix/core-service-change branch from b3653de to 70b15c0 Compare March 19, 2025 07:57
@RobPasMue RobPasMue force-pushed the fix/core-service-change branch from 70b15c0 to dd0bfdc Compare March 19, 2025 07:57
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 19, 2025
@RobPasMue RobPasMue merged commit 497b0dd into main Mar 19, 2025
47 of 48 checks passed
@RobPasMue RobPasMue deleted the fix/core-service-change branch March 19, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeometryCoreService fails to open a file
3 participants