Skip to content

feat: Remove rounds #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 20, 2025
Merged

feat: Remove rounds #1851

merged 13 commits into from
Mar 20, 2025

Conversation

smereu
Copy link
Contributor

@smereu smereu commented Mar 19, 2025

Description

Exposes the ability to remove rounds. The round faces to be removed are input to the method. The functionality was available in previous versions of the API server but CoreServices probably did not implement it until recently. I am using min version 25, 2 decorator but I can change it as needed.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

pyansys-ci-bot and others added 5 commits February 17, 2025 14:31
Remove rounds was in the API server for a while but I am not sure it was working in CoreServices prior to 25.2 so I am using the min backend decorator
@smereu smereu self-assigned this Mar 19, 2025
@smereu smereu requested a review from a team as a code owner March 19, 2025 14:29
@smereu smereu changed the title Feat:: Remove rounds Feat: Remove rounds Mar 19, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Mar 19, 2025
@RobPasMue RobPasMue changed the title Feat: Remove rounds feat: Remove rounds Mar 19, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks perfect. Just left some potential enhancements. I see the tests are failing but once that's in we should be good to merge! Thanks @smereu

@RobPasMue
Copy link
Member

@smereu - tests were failing because the proto API was expecting "selection" and not "faces". I just modified it and committed the change. Tests should pass after this change I guess.

17c1acc

BTW - which is the service version in which this API was implemented? Since CoreService is not available earlier than 25R2, it is not a problem. We can probably add the first version in which this API was added

@RobPasMue
Copy link
Member

RobPasMue commented Mar 20, 2025

Okay so it seems that the API was available as of 24.1 (just checked with @b-matteo). So we do not need to add the decorator in that case. I will take over a few changes in this PR to align it to other prepare tools (typehints & docstrings). I want to get it in before we merge blitz into main - and that should happen today.

@RobPasMue RobPasMue enabled auto-merge (squash) March 20, 2025 09:37
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.10%. Comparing base (371d89a) to head (4886ea5).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
src/ansys/geometry/core/tools/prepare_tools.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1851      +/-   ##
==========================================
- Coverage   90.12%   90.10%   -0.02%     
==========================================
  Files          92       92              
  Lines        8810     8823      +13     
==========================================
+ Hits         7940     7950      +10     
- Misses        870      873       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit d902047 into blitz Mar 20, 2025
24 of 25 checks passed
@RobPasMue RobPasMue deleted the feat/remove_rounds branch March 20, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants