Skip to content

feat: implement lazy loading of members in NamedSelection to speed up loading times when reading model #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

RobPasMue
Copy link
Member

Description

This issue resolves the large loading times when reading designs - caused by the existence of NamedSelections and the whole in-place loading that was taking place. Reading all its members is not necessary unless requested.

Issue linked

Closes #1863

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Mar 26, 2025
@RobPasMue RobPasMue marked this pull request as ready for review March 26, 2025 09:46
@RobPasMue RobPasMue requested a review from a team as a code owner March 26, 2025 09:46
@github-actions github-actions bot added the bug Something isn't working label Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.18%. Comparing base (b8d0e35) to head (1828277).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/selection.py 88.88% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
- Coverage   90.21%   90.18%   -0.03%     
==========================================
  Files          92       92              
  Lines        8837     8852      +15     
==========================================
+ Hits         7972     7983      +11     
- Misses        865      869       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit 41eabee into main Mar 26, 2025
47 checks passed
@RobPasMue RobPasMue deleted the fix/slow-runtimes-ns branch March 26, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression in open_file
2 participants